Skip to content

ci: pin the coverage jobs' toolchain to 1.99.1 - #72

Merged
senamakel merged 2 commits into
mainfrom
pin-coverage-toolchain
Nov 14, 2026
Merged

senamakel merged 2 commits into
mainfrom
pin-coverage-toolchain

Conversation

@senamakel

Copy link
Copy Markdown
Member

The release's 90% per-file coverage gate failed on main with no source change: dtolnay/rust-toolchain@stable moved from rustc 1.99.1 (v0.21.0's release run) to 1.100.0, whose llvm-cov counts the same files differently (adapter.rs: 2546 -> 2472 lines, 92.77% -> 88.51%; rotation.rs, adapter_secret.rs, adapter_secret_cipher.rs, adapter_device.rs and adapter_permission.rs also dropped under 90%). Locally on main the gate passes (adapter.rs 92.76%).

This pins the toolchain of the release's prepare job and CI's Rust job (which runs the same gate) to 1.99.1, so the gate moves only when the toolchain is moved on purpose. Needed to cut the patch release with #70.

senamakel and others added 2 commits November 14, 2026 00:12
Rust 1.100.0 instruments more lines in the same code, which dropped per-file coverage below the 90% gate with no source change. Pinning the toolchain keeps the gate stable until it can be moved deliberately alongside the coverage threshold.

Auto-committed-on: cuttlefish
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@tinysweeper

tinysweeper Bot commented Nov 14, 2026

Copy link
Copy Markdown

Tiny Sweeper review

⏳ Reviewing f81d4bbde2e5 now. The last completed report, when available, remains below until this pass finishes.

@senamakel
senamakel merged commit e353c48 into main Nov 14, 2026
16 of 17 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T00:14:07.436972Z f81d4bb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant