Repository navigation
ci: pin the coverage jobs' toolchain to 1.99.1 - #72
Merged
Merged
Conversation
Rust 1.100.0 instruments more lines in the same code, which dropped per-file coverage below the 90% gate with no source change. Pinning the toolchain keeps the gate stable until it can be moved deliberately alongside the coverage threshold. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper review
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release's 90% per-file coverage gate failed on main with no source change: dtolnay/rust-toolchain@stable moved from rustc 1.99.1 (v0.21.0's release run) to 1.100.0, whose llvm-cov counts the same files differently (adapter.rs: 2546 -> 2472 lines, 92.77% -> 88.51%; rotation.rs, adapter_secret.rs, adapter_secret_cipher.rs, adapter_device.rs and adapter_permission.rs also dropped under 90%). Locally on main the gate passes (adapter.rs 92.76%).
This pins the toolchain of the release's prepare job and CI's Rust job (which runs the same gate) to 1.99.1, so the gate moves only when the toolchain is moved on purpose. Needed to cut the patch release with #70.